fix: add more measures to prevent using data-cache for blob operations #2775
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.03%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
force-pushed
the
michalpiechowiak/frb-1686-try-to-store-unpatched-fetch-earlier
branch
from
6d77ce4 to
adb7ab3
Compare
orinokai
approved these changes
Mar 17, 2025
| attemptToGetOriginalFetch(globalThis.fetch), | ||
| ) | ||
| const getFetchBeforeNextPatchedIt = () => | ||
| extendedGlobalThis[FETCH_BEFORE_NEXT_PATCHED_IT] ?? fetchBeforeNextPatchedItFallback |
There was a problem hiding this comment.
Is this necessary? You're calling setFetchBeforeNextPatchedIt in the global scope of server.ts, so would the fallback ever be used?
There was a problem hiding this comment.
It should not be needed when running full on server handler, no.
I did want to make this module to not necessarily rely on setup (might be useful for unit tests, tho not sure if we actually have any that would would fall into using this module today)
There was a problem hiding this comment.
This is also just using pattern of allowing few points of failure because of overall messiness with patched fetch - if for whatever reason we don't call setFetchBeforeNextPatchedIt before we execute getFetchBeforeNextPatchedIt - I do want to use rest of defensive measures (such as trying to grab _originalFetch first and ultimately adding next.internal = true param to fetch calls) and continue to have this fallback just fits the best here (IMO)
There was a problem hiding this comment.
So I'll go ahead and merge as-is
pieh
deleted the
michalpiechowiak/frb-1686-try-to-store-unpatched-fetch-earlier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current way of attempting to use unpatched fetch for blob operations seems not sufficient so this change attempt to make sure we avoid this by doing couple of things:
fetchwrapper that would force setnext.internal = truein RequestInit argument as that's how Vercel's data fetch seems to ensure their suspense-cache requests don't get accidental and not intentional fetch caching.Relevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1686/try-to-store-unpatched-fetch-earlier