fix: apply caching headers to pages router 404 with getStaticProps #2764

pieh · 2025-02-13T20:00:03Z

Description

UPDATE: the scope of this PR has been reduced until we have the means to implement this via the adapter pattern. Since we can't release this breaking change until v6 anyway, the PR is now a temporary measure to cache only the 404 page when accessed directly.

The original PR description is below.

--

404 responses are currently uncached and this PR introduces cache control headers that are consistent with those generated by Vercel

The change is breaking, as some customers may be relying on the current behaviour, so it is behind an env var for now, but it paves the way to releasing this in the next major version bump.

Tests

Integration tests added

Relevant links (GitHub issues, etc.) or a picture of cute animal

Fixes https://linear.app/netlify/issue/FRB-1636/404-page-with-getstaticprops-is-not-cached-on-cdn

github-actions · 2025-02-13T20:02:16Z

📊 Package size report `0.01%↑`

File	Before (Size / Gzip)	After (Size / Gzip)
`dist/build/content/prerendered.js`	`9.2 kB` / `2.8 kB`	^1%↑`9.4 kB` / ^0.3%↑`2.8 kB`
`dist/run/handlers/cache.cjs`	`20.9 kB` / `5.6 kB`	^0.9%↑`21.1 kB` / ^0.4%↑`5.6 kB`
`dist/run/headers.js`	`7.7 kB` / `2.3 kB`	^4%↑`8.0 kB` / ^4%↑`2.4 kB`
Total _{(Includes all files)}	`5.8 MB` / `1.2 MB`	^0.01%↑`5.8 MB` / ^0.01%↑`1.2 MB`
Tarball size	`1.2 MB`	^0.01%↑`1.2 MB`

Unchanged files

File	Size (Size / Gzip)
`dist/build/advanced-api-routes.js`	`4.3 kB` / `1.4 kB`
`dist/build/cache.js`	`1.0 kB` / `414 B`
`dist/build/content/next-shims/telemetry-storage.cjs`	`1.6 kB` / `659 B`
`dist/build/content/server.js`	`8.7 kB` / `2.8 kB`
`dist/build/content/static.js`	`4.1 kB` / `1.4 kB`
`dist/build/functions/edge.js`	`20.8 kB` / `5.6 kB`
`dist/build/functions/server.js`	`5.0 kB` / `1.6 kB`
`dist/build/image-cdn.js`	`54.0 kB` / `11.1 kB`
`dist/build/plugin-context.js`	`10.1 kB` / `3.0 kB`
`dist/build/templates/handler-monorepo.tmpl.js`	`1.7 kB` / `703 B`
`dist/build/templates/handler.tmpl.js`	`1.6 kB` / `655 B`
`dist/build/verification.js`	`4.5 kB` / `1.5 kB`
`dist/esm-chunks/chunk-5QSXBV7L.js`	`2.4 kB` / `842 B`
`dist/esm-chunks/chunk-APO262HE.js`	`61.2 kB` / `11.1 kB`
`dist/esm-chunks/chunk-GNGHTHMQ.js`	`55.6 kB` / `9.7 kB`
`dist/esm-chunks/chunk-KGYJQ2U2.js`	`186.5 kB` / `32.9 kB`
`dist/esm-chunks/chunk-OEQOKJGE.js`	`2.3 kB` / `977 B`
`dist/esm-chunks/package-CPHFXJWM.js`	`3.6 kB` / `1.4 kB`
`dist/index.js`	`3.4 kB` / `1.1 kB`
`dist/run/config.js`	`1.2 kB` / `595 B`
`dist/run/constants.js`	`516 B` / `308 B`
`dist/run/handlers/request-context.cjs`	`5.8 kB` / `1.8 kB`
`dist/run/handlers/server.js`	`141.3 kB` / `33.1 kB`
`dist/run/handlers/tracer.cjs`	`29.9 kB` / `6.3 kB`
`dist/run/handlers/tracing.js`	`3.0 MB` / `418.4 kB`
`dist/run/handlers/wait-until.cjs`	`1.4 kB` / `665 B`
`dist/run/next.cjs`	`23.6 kB` / `5.8 kB`
`dist/run/regional-blob-store.cjs`	`19.6 kB` / `5.5 kB`
`dist/run/revalidate.js`	`1.0 kB` / `475 B`
`dist/shared/blobkey.js`	`742 B` / `399 B`
`dist/shared/cache-types.cjs`	`1.3 kB` / `566 B`
`edge-runtime/lib/headers.ts`	`1.9 kB` / `841 B`
`edge-runtime/lib/logging.ts`	`115 B` / `121 B`
`edge-runtime/lib/middleware.ts`	`1.9 kB` / `807 B`
`edge-runtime/lib/next-request.ts`	`3.3 kB` / `1.1 kB`
`edge-runtime/lib/response.ts`	`9.2 kB` / `2.9 kB`
`edge-runtime/lib/routing.ts`	`15.1 kB` / `3.9 kB`
`edge-runtime/lib/util.test.ts`	`1.6 kB` / `356 B`
`edge-runtime/lib/util.ts`	`3.7 kB` / `1.3 kB`
`edge-runtime/matchers.json`	`3 B` / `23 B`
`edge-runtime/middleware.ts`	`2.4 kB` / `1.0 kB`
`edge-runtime/next.config.json`	`3 B` / `23 B`
`edge-runtime/README.md`	`992 B` / `509 B`
`edge-runtime/shim/index.js`	`1.5 kB` / `717 B`
`edge-runtime/vendor.ts`	`745 B` / `312 B`
`edge-runtime/vendor/deno.land/std@0.175.0/_util/asserts.ts`	`854 B` / `461 B`
`edge-runtime/vendor/deno.land/std@0.175.0/_util/os.ts`	`644 B` / `355 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/abortable.ts`	`4.0 kB` / `1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/deadline.ts`	`974 B` / `544 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/debounce.ts`	`2.2 kB` / `956 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/deferred.ts`	`1.5 kB` / `798 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/delay.ts`	`1.8 kB` / `845 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/mod.ts`	`465 B` / `241 B`
`edge-runtime/vendor/deno.land/std@0.175.0/async/mux_async_iterator.ts`	`2.5 kB` / `1.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/pool.ts`	`3.2 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/retry.ts`	`2.4 kB` / `1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/async/tee.ts`	`2.1 kB` / `924 B`
`edge-runtime/vendor/deno.land/std@0.175.0/bytes/index_of_needle.ts`	`1.4 kB` / `668 B`
`edge-runtime/vendor/deno.land/std@0.175.0/crypto/timing_safe_equal.ts`	`875 B` / `442 B`
`edge-runtime/vendor/deno.land/std@0.175.0/datetime/to_imf.ts`	`1.3 kB` / `681 B`
`edge-runtime/vendor/deno.land/std@0.175.0/encoding/base64.ts`	`2.5 kB` / `1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/encoding/base64url.ts`	`2.0 kB` / `872 B`
`edge-runtime/vendor/deno.land/std@0.175.0/flags/mod.ts`	`22.6 kB` / `5.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/fmt/colors.ts`	`12.4 kB` / `2.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/fmt/printf.ts`	`27.7 kB` / `7.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/http/cookie.ts`	`11.5 kB` / `3.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_core.ts`	`2.3 kB` / `716 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_events.d.ts`	`27.2 kB` / `5.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_events.mjs`	`28.0 kB` / `7.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_global.d.ts`	`1.7 kB` / `650 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_next_tick.ts`	`5.0 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/exiting.ts`	`138 B` / `138 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/process.ts`	`3.8 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/stdio.mjs`	`336 B` / `233 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_process/streams.mjs`	`4.0 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_stream.d.ts`	`53.2 kB` / `11.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_stream.mjs`	`91.2 kB` / `25.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_util/_util_callbackify.ts`	`4.3 kB` / `1.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/_utils.ts`	`5.9 kB` / `2.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/assert.ts`	`23.1 kB` / `4.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/assertion_error.ts`	`19.6 kB` / `6.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/async_hooks.ts`	`7.7 kB` / `2.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/buffer.ts`	`262 B` / `204 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/events.ts`	`303 B` / `221 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_libuv_winerror.ts`	`7.8 kB` / `1.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_listen.ts`	`561 B` / `342 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_node.ts`	`443 B` / `335 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_timingSafeEqual.ts`	`479 B` / `268 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_utils.ts`	`2.4 kB` / `938 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/_winerror.ts`	`354.4 kB` / `64.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/ares.ts`	`2.4 kB` / `1.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/async_wrap.ts`	`4.0 kB` / `1.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/buffer.ts`	`3.5 kB` / `1.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/cares_wrap.ts`	`15.2 kB` / `3.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/config.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/connection_wrap.ts`	`2.6 kB` / `1.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/constants.ts`	`21.5 kB` / `5.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/contextify.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/credentials.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/crypto.ts`	`448 B` / `244 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/errors.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/fs_dir.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/fs_event_wrap.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/fs.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/handle_wrap.ts`	`1.8 kB` / `1.0 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/heap_utils.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/http_parser.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/icu.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/inspector.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/js_stream.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/messaging.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/mod.ts`	`3.1 kB` / `955 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/module_wrap.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/native_module.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/natives.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/node_file.ts`	`2.9 kB` / `1.5 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/node_options.ts`	`1.8 kB` / `989 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/options.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/os.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/performance.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/pipe_wrap.ts`	`10.4 kB` / `3.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/process_methods.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/report.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/serdes.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/signal_wrap.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/spawn_sync.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/stream_wrap.ts`	`9.3 kB` / `2.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/string_decoder.ts`	`504 B` / `261 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/symbols.ts`	`1.4 kB` / `828 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/task_queue.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/tcp_wrap.ts`	`13.1 kB` / `3.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/timers.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/tls_wrap.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/trace_events.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/tty_wrap.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/types.ts`	`5.7 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/udp_wrap.ts`	`12.4 kB` / `3.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/url.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/util.ts`	`4.0 kB` / `1.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/uv.ts`	`20.1 kB` / `3.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/v8.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/worker.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal_binding/zlib.ts`	`87 B` / `104 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/buffer.d.ts`	`73.6 kB` / `12.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/buffer.mjs`	`66.1 kB` / `10.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/crypto/_keys.ts`	`463 B` / `262 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/crypto/constants.ts`	`252 B` / `173 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/error_codes.ts`	`322 B` / `250 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/errors.ts`	`78.9 kB` / `17.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/fixed_queue.ts`	`4.4 kB` / `1.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/hide_stack_frames.ts`	`550 B` / `377 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/net.ts`	`3.1 kB` / `1.5 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/normalize_encoding.mjs`	`2.1 kB` / `500 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/options.ts`	`1.7 kB` / `959 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/primordials.mjs`	`1.8 kB` / `431 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/process/per_thread.mjs`	`7.8 kB` / `2.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/readline/callbacks.mjs`	`3.8 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/readline/utils.mjs`	`14.3 kB` / `3.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/streams/destroy.mjs`	`6.9 kB` / `1.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/streams/end-of-stream.mjs`	`7.1 kB` / `1.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/streams/utils.mjs`	`5.9 kB` / `1.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util.mjs`	`4.0 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/comparisons.ts`	`16.6 kB` / `3.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/debuglog.ts`	`3.2 kB` / `1.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/inspect.mjs`	`71.5 kB` / `19.8 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/util/types.ts`	`3.7 kB` / `1.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/internal/validators.mjs`	`8.0 kB` / `2.1 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/process.ts`	`19.4 kB` / `5.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/stream.ts`	`671 B` / `346 B`
`edge-runtime/vendor/deno.land/std@0.175.0/node/string_decoder.ts`	`10.3 kB` / `3.3 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/util.ts`	`7.8 kB` / `2.2 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/node/util/types.ts`	`199 B` / `153 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/_constants.ts`	`2.0 kB` / `727 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/_interface.ts`	`728 B` / `369 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/_util.ts`	`5.0 kB` / `1.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/path/common.ts`	`1.2 kB` / `607 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/glob.ts`	`12.7 kB` / `3.9 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/path/mod.ts`	`1.4 kB` / `690 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/posix.ts`	`13.9 kB` / `3.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/path/separator.ts`	`259 B` / `209 B`
`edge-runtime/vendor/deno.land/std@0.175.0/path/win32.ts`	`28.5 kB` / `6.4 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/streams/write_all.ts`	`2.2 kB` / `598 B`
`edge-runtime/vendor/deno.land/std@0.175.0/testing/_diff.ts`	`11.6 kB` / `3.6 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/testing/_format.ts`	`705 B` / `462 B`
`edge-runtime/vendor/deno.land/std@0.175.0/testing/asserts.ts`	`25.5 kB` / `5.7 kB`
`edge-runtime/vendor/deno.land/std@0.175.0/types.d.ts`	`4.2 kB` / `1.2 kB`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/pkg/htmlrewriter_bg.wasm`	`573.2 kB` / `262.7 kB`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/pkg/htmlrewriter.js`	`31.0 kB` / `4.7 kB`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/src/index.ts`	`2.6 kB` / `989 B`
`edge-runtime/vendor/deno.land/x/htmlrewriter@v1.0.0/src/types.d.ts`	`2.1 kB` / `446 B`
`edge-runtime/vendor/deno.land/x/path_to_regexp@v6.2.1/index.ts`	`15.4 kB` / `4.2 kB`
`edge-runtime/vendor/import_map.json`	`148 B` / `111 B`
`edge-runtime/vendor/v1-7-0--edge-utils.netlify.app/logger/logger.ts`	`3.2 kB` / `747 B`
`edge-runtime/vendor/v1-7-0--edge-utils.netlify.app/logger/mod.ts`	`29 B` / `49 B`
`manifest.yml`	`31 B` / `51 B`
`package.json`	`3.2 kB` / `1.2 kB`
`README.md`	`2.8 kB` / `1.2 kB`

_{🤖 This report was automatically generated by pkg-size-action}

tests/integration/page-router.test.ts

src/run/headers.ts

src/run/handlers/cache.cts

src/build/content/prerendered.ts

src/run/headers.ts

… to limit potentially unwanted impact of the change

…od would have set cacheable header

src/run/headers.ts

tests/integration/page-router.test.ts

src/run/headers.ts

fix: apply caching headers to pages router 404 with getStaticProps

330dca0

pieh force-pushed the fix/caching-headers-for-get-static-props-404 branch from bac472e to 330dca0 Compare February 13, 2025 20:01

pieh commented Feb 13, 2025

View reviewed changes

tests/integration/page-router.test.ts Outdated Show resolved Hide resolved

pieh commented Feb 14, 2025

View reviewed changes

src/run/headers.ts Outdated Show resolved Hide resolved

pieh commented Feb 14, 2025

View reviewed changes

src/run/handlers/cache.cts Outdated Show resolved Hide resolved

orinokai reviewed Feb 14, 2025

View reviewed changes

src/build/content/prerendered.ts Show resolved Hide resolved

src/run/headers.ts Show resolved Hide resolved

pieh and others added 8 commits February 17, 2025 11:57

chore: don't store revalidate on request context for app router pages…

bdfb31a

… to limit potentially unwanted impact of the change

chore: don't apply new 404 caching header code path, if existing meth…

c1712f8

…od would have set cacheable header

test: add notFound cases for 404 with getStaticProps without revalidate

7b947dc

test: add fixture for 404 with getStaticProps with revalidate

3423330

tmp: outline 404 integration test cases for page router

Loading
Loading status checks…

25ad18c

test: update 404 caching tests

bbedbdb

fix: relax the conditions for caching 404s

3ea9375

test: remove only

5d91e73

orinokai reviewed Feb 24, 2025

View reviewed changes

src/run/headers.ts Show resolved Hide resolved

src/run/headers.ts Show resolved Hide resolved

tests/integration/page-router.test.ts Show resolved Hide resolved

orinokai added 3 commits February 24, 2025 10:55

Merge branch 'main' into fix/caching-headers-for-get-static-props-404

81a2338

feat: hide 404 caching behind env var

2962d0b

test: remove only and console logs

238e6e6

orinokai marked this pull request as ready for review February 25, 2025 13:40

orinokai added 2 commits February 25, 2025 14:58

test: update static 404 test

bb64d82

Merge branch 'main' into fix/caching-headers-for-get-static-props-404

45ce211

orinokai marked this pull request as draft February 26, 2025 10:53

feat: reduce 404 caching scope to just the 404 page itself

f31d30c

orinokai marked this pull request as ready for review February 27, 2025 18:22

orinokai reviewed Feb 27, 2025

View reviewed changes

src/run/headers.ts Show resolved Hide resolved

orinokai added 3 commits February 27, 2025 19:18

test: remove only modifier

a6f37e2

test: fix tests for new custom 404 pate

70a3ae6

Merge branch 'main' into fix/caching-headers-for-get-static-props-404

cfb3086

orinokai merged commit 3301077 into main Mar 6, 2025
29 of 30 checks passed

orinokai deleted the fix/caching-headers-for-get-static-props-404 branch March 6, 2025 11:50

orinokai mentioned this pull request Mar 6, 2025

chore(main): release 5.10.0 #2770

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: apply caching headers to pages router 404 with getStaticProps #2764

fix: apply caching headers to pages router 404 with getStaticProps #2764

pieh commented Feb 13, 2025 •

edited by orinokai

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

fix: apply caching headers to pages router 404 with getStaticProps #2764

fix: apply caching headers to pages router 404 with getStaticProps #2764

Conversation

pieh commented Feb 13, 2025 • edited by orinokai Loading

Description

Tests

Relevant links (GitHub issues, etc.) or a picture of cute animal

github-actions bot commented Feb 13, 2025 • edited Loading

📊 Package size report 0.01%↑

pieh commented Feb 13, 2025 •

edited by orinokai

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

📊 Package size report `0.01%↑`