Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependecies that support css variables #105

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Feb 28, 2025

This PR updates frontend-plugin-framework with the compatibility for CSS Variables and Design Tokens, the new styling paradigm for the frontend.

Changes:

  1. Update paragon to a version 23.x
  2. Update frontend-platform to version 8.3

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 28, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 28, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (e755be4) to head (26b8021).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          10       10           
  Lines         236      236           
  Branches       71       71           
=======================================
  Hits          226      226           
  Misses          9        9           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa
Copy link
Contributor Author

dcoa commented Mar 6, 2025

Hi @brian-smith-tcril this PR is ready for review, I noticed that should be addressed first as been used in header and footer as dependency.

Could you please review it before the other dependencies?

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally against frontend-app-learner-dashboard by pulling this branch, building this branch using npm run build, and updating module.config.js in frontend-app-learner-dashboard to point to the dist directory of this branch for frontend-plugin-framework.

🎉 Everything seems to be working as expected! 🎉

@dcoa would you be OK with me using squash to merge this and changing the commit message from chore: to feat:? chore: commits don't kick off new releases, and we'll want to make sure a new version of frontend-plugin-framework is published when this lands.

@dcoa dcoa changed the title chore: update dependecies that support css variables feat: update dependecies that support css variables Mar 10, 2025
@dcoa
Copy link
Contributor Author

dcoa commented Mar 10, 2025

Excellent @brian-smith-tcril, yes it is a good idea change the commit name and squash it during the merge

@brian-smith-tcril brian-smith-tcril merged commit 09ff704 into openedx:master Mar 10, 2025
6 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants