-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update dependecies that support css variables #105
feat: update dependecies that support css variables #105
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 10 10
Lines 236 236
Branches 71 71
=======================================
Hits 226 226
Misses 9 9
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @brian-smith-tcril this PR is ready for review, I noticed that should be addressed first as been used in header and footer as dependency. Could you please review it before the other dependencies? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this locally against frontend-app-learner-dashboard
by pulling this branch, building this branch using npm run build
, and updating module.config.js
in frontend-app-learner-dashboard
to point to the dist
directory of this branch for frontend-plugin-framework
.
🎉 Everything seems to be working as expected! 🎉
@dcoa would you be OK with me using squash to merge this and changing the commit message from chore:
to feat:
? chore:
commits don't kick off new releases, and we'll want to make sure a new version of frontend-plugin-framework
is published when this lands.
Excellent @brian-smith-tcril, yes it is a good idea change the commit name and squash it during the merge |
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR updates frontend-plugin-framework with the compatibility for CSS Variables and Design Tokens, the new styling paradigm for the frontend.
Changes:
paragon
to a version 23.xfrontend-platform
to version 8.3