Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openebs/dynamic-localpv-provisioner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.3
Choose a base ref
...
head repository: openebs/dynamic-localpv-provisioner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.4
Choose a head ref
  • 2 commits
  • 3 files changed
  • 3 contributors

Commits on Jan 22, 2025

  1. chore(ci): update helm chart versions and/or git submodules (#232) 

    Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: niladrih <niladrih@users.noreply.github.com>
    @github-actions @niladrih
    github-actions[bot] and niladrih authored Jan 22, 2025
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9a097de View commit details

  2. refactor(charts): make priorityClassName template-able (#233) 

    Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
    @niladrih
    niladrih authored Jan 22, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    02555d6 View commit details
Showing with 5 additions and 5 deletions.
  1. +2 −2 deploy/helm/charts/Chart.yaml
  2. +2 −2 deploy/helm/charts/templates/deployment.yaml
  3. +1 −1 deploy/helm/charts/values.yaml
4 changes: 2 additions & 2 deletions deploy/helm/charts/Chart.yaml
View file
Original file line number Diff line number Diff line change
@@ -4,10 +4,10 @@ description: Helm chart for OpenEBS Dynamic Local PV. For instructions to instal
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 4.1.2-prerelease
version: 4.1.4-prerelease
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 4.1.2-prerelease
appVersion: 4.1.4-prerelease
icon: https://raw.githubusercontent.com/cncf/artwork/master/projects/openebs/icon/color/openebs-icon-color.png
home: http://www.openebs.io/
keywords:
4 changes: 2 additions & 2 deletions deploy/helm/charts/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
@@ -33,8 +33,8 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- with .Values.localpv.priorityClassName }}
priorityClassName: {{ . }}
{{- if .Values.localpv.priorityClassName }}
priorityClassName: {{ tpl .Values.localpv.priorityClassName . }}
{{- end }}
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
2 changes: 1 addition & 1 deletion deploy/helm/charts/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ localpv:
# For example : quay.io/ is a correct value here and quay.io is incorrect
registry:
repository: openebs/provisioner-localpv
tag: 4.1.2-prerelease
tag: 4.1.4-prerelease
pullPolicy: IfNotPresent
updateStrategy:
type: RollingUpdate