Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features.md: add unsafe annotation list #1202

Closed
AkihiroSuda opened this issue May 16, 2023 · 2 comments · Fixed by #1205
Closed

features.md: add unsafe annotation list #1202

AkihiroSuda opened this issue May 16, 2023 · 2 comments · Fixed by #1205
Milestone

Comments

@AkihiroSuda
Copy link
Member

https://github.com/opencontainers/runtime-spec/blob/main/features.md should return the list of unsafe annotations. (“org.systemd.”, “run.oci.”, etc.)

@cyphar
Copy link
Member

cyphar commented May 16, 2023

I like this idea, though I think runtimes should opt for listing the precise annotations they consider unsafe rather than specifying namespaces (after all, the runtime should know which annotations they support and what they do). But the format should probably support specifying namespaces in cases where the runtime really wants to indicate a whole namespace is unsafe.

@AkihiroSuda
Copy link
Member Author

PR:

I like this idea, though I think runtimes should opt for listing the precise annotations they consider unsafe rather than specifying namespaces (after all, the runtime should know which annotations they support and what they do). But the format should probably support specifying namespaces in cases where the runtime really wants to indicate a whole namespace is unsafe.

Yes.
Actually, a precise annotation string is also valid as a "prefix"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants