Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: add cpu idle #1145

Merged
merged 1 commit into from May 5, 2022
Merged

schema: add cpu idle #1145

merged 1 commit into from May 5, 2022

Conversation

giuseppe
Copy link
Member

commit 9d363b3 added the feature but
didn't update the json schema file.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe
schema: add cpu idle
bc545ec 
commit 9d363b3 added the feature but
didn't update the json schema file.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this pull request Apr 20, 2022
Merged
vbatts
vbatts approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah. I wish there was a CI to block on missing schema coverage

@giuseppe
Copy link
Member Author

@crosbymichael @cyphar @dqminh @hqhq @mrunalp @tianon PTAL

tianon
tianon approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need any changes for #1146, right?

@giuseppe
Copy link
Member Author

giuseppe commented May 2, 2022

This doesn't need any changes for #1146, right?

I think we should be fine. #1146 is just a fix for the Go library to make clear when the value was specified in the configuration.

In the example we have in config.md:

            "cpu": {
                "shares": 1024,
                "quota": 1000000,
                "period": 500000,
                "realtimeRuntime": 950000,
                "realtimePeriod": 1000000,
                "cpus": "2-3",
                "idle": 1,
                "mems": "0-7"
            },

idle has just the int64 value and it follows the schema update proposed here

kolyshkin
kolyshkin approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon tianon merged commit 2792412 into opencontainers:main May 5, 2022
@kolyshkin kolyshkin mentioned this pull request May 9, 2022
Closed
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
Merged
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbatts vbatts vbatts approved these changes

@tianon tianon tianon approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@flouthoc flouthoc flouthoc approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

@hqhq hqhq Awaiting requested review from hqhq hqhq is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@giuseppe @vbatts @tianon @kolyshkin @flouthoc @AkihiroSuda