Add support for SCMP_ACT_KILL_THREAD #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The seccomp action has been added to libseccomp a while ago, so I guess the runtime spec should support it as well: seccomp/libseccomp@b2f15f3 Signed-off-by: Sascha Grunert <sgrunert@suse.com>
mrunalp
approved these changes
Oct 8, 2020
|
LGTM |
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
May 4, 2022
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
crazy-max
pushed a commit
to crazy-max/runc
that referenced
this pull request
May 4, 2022
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit e74fdeb)
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
May 20, 2022
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit e74fdeb) (cherry picked from commit 68427f3) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
May 20, 2022
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit e74fdeb) (cherry picked from commit 68427f3) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seccomp action has been added to libseccomp a while ago, so I guess
the runtime spec should support it as well:
seccomp/libseccomp@b2f15f3