seccomp: allow to override errno return code #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some seccomp actions allow to specify the errno code returned for the syscall. Add a new attribute to the seccomp syscall so the default EPERM can be overriden. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM |
|
LGTM |
|
@opencontainers/runtime-spec-maintainers ptal. |
|
@cyphar @crosbymichael @vbatts ptal. |
|
LGTM |
|
Yeah, LGTM as well. |
|
sorry 😞 I've messed up the Go specs (noticed as I am working on its implementation in runc), I've opened a new PR to fix it: #1042 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some seccomp actions allow to specify the errno code returned for the
syscall.
Add a new attribute to the seccomp syscall so the default EPERM can be
overriden.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com