Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1 backport] fix typos #4055

Merged
merged 2 commits into from Oct 4, 2023
Merged

[1.1 backport] fix typos #4055

merged 2 commits into from Oct 4, 2023

Conversation

lifubang
Copy link
Member

@lifubang lifubang commented Oct 4, 2023 •
edited by kolyshkin

This fixes CI for release-1.1 branch

(cherry picked from commit 109dcad)

Run codespell
  codespell
  shell: /usr/bin/bash -e {0}
  env:
    GO_VERSION: 1.20.x
./man/runc-update.8.md:45: limtis ==> limits
./libcontainer/seccomp/patchbpf/enosys_linux.go:92: explcitly ==> explicitly
Error: Process completed with exit code 65.

This pr also fix an new typo:

Run codespell
  codespell
  shell: /usr/bin/bash -e {0}
  env:
    GO_VERSION: 1.20.x
./libcontainer/nsenter/cloned_binary.c:154: re-use ==> reuse
Error: Process completed with exit code 65.

@lifubang
fix two typos
8f66c9f 
Signed-off-by: lifubang <lifubang@acmcoder.com>
(cherry picked from commit 109dcad)
Signed-off-by: lifubang <lifubang@acmcoder.com>
@lifubang
fix a typo in cloned_binary.c: re-use -> reuse
b365458 
Signed-off-by: lifubang <lifubang@acmcoder.com>
kolyshkin
kolyshkin approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added this to the 1.1.10 milestone Oct 4, 2023
@kolyshkin kolyshkin changed the title [1.1 backport] fix two typos [1.1 backport] fix typos Oct 4, 2023
@AkihiroSuda AkihiroSuda merged commit ad9c301 into opencontainers:release-1.1 Oct 4, 2023
29 checks passed
@lifubang lifubang added the backport/1.1-pr A backport to 1.1.x release. label Oct 7, 2023
@kolyshkin kolyshkin mentioned this pull request Oct 24, 2023
Closed
@cyphar cyphar mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Assignees
No one assigned
Labels
backport/1.1-pr A backport to 1.1.x release. easy-to-review
Projects
None yet
Milestone
1.1.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lifubang @kolyshkin @AkihiroSuda