Add riscv64 arch to check{Architecture|Platform}
#1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
michalbiesek
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sudo-bmitch,
sajayantony,
tianon,
vbatts and
cyphar
as code owners
sudo-bmitch
approved these changes
Aug 12, 2023
tianon
approved these changes
Aug 17, 2023
| @@ -232,7 +233,7 @@ func checkPlatform(OS string, Architecture string) { | |||
| "darwin": {"386", "amd64", "arm", "arm64"}, | |||
| "dragonfly": {"amd64"}, | |||
| "freebsd": {"386", "amd64", "arm"}, | |||
| "linux": {"386", "amd64", "arm", "arm64", "ppc64", "ppc64le", "mips64", "mips64le", "s390x"}, | |||
| "linux": {"386", "amd64", "arm", "arm64", "ppc64", "ppc64le", "mips64", "mips64le", "s390x", "riscv64"}, | |||
There was a problem hiding this comment.
IMO we should sort these, but I'm also not sure what this file is for (why are we hand-maintaining a list of things we've delegated to Go to define specifically partly so we don't have to hand-maintain such a list?).
Suggested change
| "linux": {"386", "amd64", "arm", "arm64", "ppc64", "ppc64le", "mips64", "mips64le", "s390x", "riscv64"}, | |
| "linux": {"386", "amd64", "arm", "arm64", "mips64", "mips64le", "ppc64", "ppc64le", "riscv64", "s390x"}, |
I don't feel super strongly though given that the list is already not in proper sorted order (and am thus approving).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.