Provide a decision tree for artifacts #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sajayantony,
tianon,
vbatts and
cyphar
as code owners
tianon
reviewed
Aug 9, 2023
tianon
reviewed
Aug 9, 2023
tianon
reviewed
Aug 9, 2023
tianon
requested changes
Aug 9, 2023
sudo-bmitch
force-pushed
the
pr-artifact-workflow
branch
from
16e207f
to
72b3fb0
Compare
ChaoyiHuang
reviewed
Aug 10, 2023
sudo-bmitch
force-pushed
the
pr-artifact-workflow
branch
from
72b3fb0
to
dab402d
Compare
Signed-off-by: Brandon Mitchell <git@bmitch.net> Helped-by: Dasith Wijesiriwardena <dasiths@hotmail.com>
sudo-bmitch
force-pushed
the
pr-artifact-workflow
branch
from
dab402d
to
e6a75e6
Compare
sajayantony
approved these changes
Aug 11, 2023
1 task
tianon
approved these changes
Aug 17, 2023
Comment on lines
+4
to
+5
| When this is done, the `config.mediaType` value should not be a known OCI image config [media type](media-types.md). | ||
| Historically, due to registry limitations, some tools have created non-OCI conformant artifacts using the `application/vnd.oci.image.config.v1+json` value for `config.mediaType` and values specific to the artifact in `layer[*].mediaType`. |
There was a problem hiding this comment.
👍 on the updated language here ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a decision tree to the artifact guidance to indicate when the artifactType field should and should not be used. I believe this closes #1100.