Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: open-wc/custom-elements-manifest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 24fc86b531f3875b6c78dafc1316b88b6516218d
Choose a base ref
...
head repository: open-wc/custom-elements-manifest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e60cb142aa257d8918f18545b8cdcd7f18f2dcff
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Apr 24, 2024

  1. fix: createRenderRoot lit method denylist

    @thepassle
    thepassle committed Apr 24, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    e60cb14 View commit details
3 changes: 3 additions & 0 deletions packages/analyzer/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## Release 0.9.6
- Added `createRenderRoot` to lit's method denylist

## Release 0.9.5
- When using `litPlugin`, it now removes overriden lit specific lifecycle methods to be aligned with the behavior of overriding lit specific lifecycle methods in classes

2 changes: 1 addition & 1 deletion packages/analyzer/browser/index.js
View file
Original file line number Diff line number Diff line change
@@ -205153,7 +205153,7 @@ var fastPlugin = () => [

// src/features/framework-plugins/lit/method-denylist.js
function methodDenyListPlugin2() {
const METHOD_DENY_LIST = ["requestUpdate", "performUpdate", "shouldUpdate", "update", "render", "firstUpdated", "updated", "willUpdate"];
const METHOD_DENY_LIST = ["requestUpdate", "createRenderRoot", "performUpdate", "shouldUpdate", "update", "render", "firstUpdated", "updated", "willUpdate"];
return {
name: "CORE - LIT-METHOD-DENYLIST",
moduleLinkPhase({ moduleDoc }) {
2 changes: 1 addition & 1 deletion packages/analyzer/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@custom-elements-manifest/analyzer",
"version": "0.9.5",
"version": "0.9.6",
"description": "",
"license": "MIT",
"type": "module",
2 changes: 1 addition & 1 deletion packages/analyzer/src/features/framework-plugins/lit/method-denylist.js
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
* Excludes methods from the manifest
*/
export function methodDenyListPlugin() {
const METHOD_DENY_LIST = ['requestUpdate', 'performUpdate', 'shouldUpdate', 'update', 'render', 'firstUpdated', 'updated', 'willUpdate'];
const METHOD_DENY_LIST = ['requestUpdate', 'createRenderRoot', 'performUpdate', 'shouldUpdate', 'update', 'render', 'firstUpdated', 'updated', 'willUpdate'];

return {
name: 'CORE - LIT-METHOD-DENYLIST',