-
Notifications
You must be signed in to change notification settings - Fork 517
Tonic Interceptor #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tonic Interceptor #901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started, makes sense to have interceptor support, added some comments.
12833e1
to
307478f
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
=====================================
Coverage 69.9% 69.9%
=====================================
Files 116 116
Lines 9027 9027
=====================================
Hits 6316 6316
Misses 2711 2711 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bump @jtescher Is anything else you would like to see on this PR? Getting this auth setup working is becoming a higher priority for our team, so would be great to get this integrated. |
Sorry didn't get a chance to take a look over the weekend. I will take a look before cut 0.19 release |
Is this the only item going into the 0.19 release? If so what needs to be done to move this forward? We would really like to start migrating our metrics, but this has been a blocking issue for us. |
@blogle Not a comment on the PR content, but a general rule - the CLA check must be cleared before any PRs can be accepted. Could you sign the CLA check? (you may need to consult your employer to see if there are any legal steps to be followed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've addressed @jtescher suggestions but yes you'll need to need to sign the CLA.
Thank you for your contribution!
Probably need to address the lint issue also. But I can take a look if needed |
CLA should now be cleared up. @TommyCpp as for the lints, I believe those |
Looks like it needs your approval cc @jtescher |
I have pushed a change to fix the lint issue and make the configurations public |
Adds optional config for an interceptor to enable modifying each outbound metrics request.
For example - my company has a centralized opentelemetry-collector that gives our SRE team flexibility to determine where they should pipe and store metrics that feed into grafana. This central collector sits behind google IAP. Each internal service needs to supply an oauth token in the grpc headers to publish metrics to this endpoint. This PR exposes the machinery for applications to access the request object and supply such metadata.