-
Notifications
You must be signed in to change notification settings - Fork 513
Add base64 conversion traits #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xd009642 yeah this direction looks good, maybe have this be an optional feature like serde is currently? Nice to keep the dependency list short for people who don't need all the features. |
I can do that once I finish work today 👍 base64 is a small dependency though with no subdependencies so should I at least make it a default feature? |
also I signed the cla/linuxfoundation so I guess that will switch to pass on the next commit I push? |
Sounds good! Normally I think default feature could make sense, however the binary format is in flux / may be removed so probably best to have this be opt-in for now. |
Starting work on tests
@jtescher I've moved base64 to it's own feature and also decided to do a blanket implementation for anything that implements |
I signed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! do you want to also export this in the api
module to make it a little more ergonomic for consumers? nice to be able to use at that level: use api::Base64Format
Done 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
## Motivation As described in open-telemetry#81, currently the metrics layer doesn't do anything when Debug / Display values are given. ## Solution Record `Debug` attributes as otel metric attributes.
I'll add some tests and more doc comments later just wanted to make sure this was in the ballpark of what was expected.
Fixes #54