Simplify trace core traits #664
Merged
+38
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the `std::fmt::Debug` and `'static` requirements from the `TracerProvider`, `Tracer`, and `Span` traits as they are not generally necessary. `'static` is only required in the global module context.
Codecov Report
@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 63.41% 63.81% +0.39%
==========================================
Files 95 95
Lines 7796 7748 -48
==========================================
Hits 4944 4944
+ Misses 2852 2804 -48
Continue to review full report at Codecov.
|
# Conflicts: # opentelemetry/src/trace/tracer_provider.rs
realtimetodie
pushed a commit
to realtimetodie/opentelemetry-rust
that referenced
this pull request
Dec 4, 2021
* Simplify trace core traits This patch removes the `std::fmt::Debug` and `'static` requirements from the `TracerProvider`, `Tracer`, and `Span` traits as they are not generally necessary. `'static` is only required in the global module context. * Remove tests that rely on debug impls * Fix clippy lints Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
realtimetodie
pushed a commit
to realtimetodie/opentelemetry-rust
that referenced
this pull request
Dec 4, 2021
* Simplify trace core traits This patch removes the `std::fmt::Debug` and `'static` requirements from the `TracerProvider`, `Tracer`, and `Span` traits as they are not generally necessary. `'static` is only required in the global module context. * Remove tests that rely on debug impls * Fix clippy lints Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the
std::fmt::Debugand'staticrequirements from theTracerProvider,Tracer, andSpantraits as they are not generally necessary.'staticis only required in the global module context.