-
Notifications
You must be signed in to change notification settings - Fork 517
Fix default resource detection for tracer provider #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 61.98% 62.08% +0.10%
==========================================
Files 95 95
Lines 7683 7705 +22
==========================================
+ Hits 4762 4784 +22
Misses 2921 2921
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks! really love the unit tests.
@jtescher Any more comments or it's good to merge? |
@TommyCpp one last issue to resolve one way or the other |
Spec says