Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more resource detectors #573

Merged
merged 2 commits into from Jun 16, 2021

Conversation

TommyCpp
Copy link
Contributor

Also updated the grpc proto generated files.

@TommyCpp TommyCpp requested a review from a team as a code owner June 16, 2021 03:26
@TommyCpp TommyCpp changed the title Add more resource detectors feat: add more resource detectors Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #573 (eefa20d) into main (efbc842) will increase coverage by 0.2%.
The diff coverage is 88.8%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #573     +/-   ##
=======================================
+ Coverage   54.4%   54.7%   +0.2%     
=======================================
  Files         99     101      +2     
  Lines       8642    8668     +26     
=======================================
+ Hits        4709    4745     +36     
+ Misses      3933    3923     -10     
Impacted Files Coverage Δ
opentelemetry/src/sdk/resource/env.rs 82.5% <0.0%> (ø)
opentelemetry/src/sdk/resource/mod.rs 87.0% <ø> (ø)
opentelemetry/src/sdk/resource/os.rs 91.6% <91.6%> (ø)
opentelemetry/src/sdk/resource/process.rs 92.8% <92.8%> (ø)
opentelemetry/src/core.rs 75.8% <0.0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efbc842...eefa20d. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtescher jtescher merged commit 6834b64 into open-telemetry:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants