Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example and optional dependencies #568

Merged
merged 2 commits into from Jun 9, 2021
Merged

Update example and optional dependencies #568

merged 2 commits into from Jun 9, 2021

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Jun 9, 2021

No description provided.

@jtescher jtescher requested a review from a team as a code owner June 9, 2021 01:15
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #568 (7347a59) into main (dc7d81f) will decrease coverage by 0.2%.
The diff coverage is 62.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #568     +/-   ##
=======================================
- Coverage   54.7%   54.4%   -0.3%     
=======================================
  Files         98      99      +1     
  Lines       8576    8642     +66     
=======================================
+ Hits        4694    4708     +14     
- Misses      3882    3934     +52     
Impacted Files Coverage Δ
opentelemetry-datadog/src/lib.rs 92.4% <ø> (ø)
opentelemetry-http/src/lib.rs 0.0% <0.0%> (ø)
opentelemetry-zipkin/src/lib.rs 100.0% <ø> (ø)
opentelemetry/src/trace/mod.rs 50.0% <ø> (ø)
opentelemetry-jaeger/src/lib.rs 92.1% <33.3%> (-2.0%) ⬇️
opentelemetry/src/trace/span_context.rs 89.4% <68.4%> (-2.4%) ⬇️
opentelemetry-aws/src/lib.rs 91.0% <73.3%> (-2.3%) ⬇️
opentelemetry/src/sdk/trace/tracer.rs 85.9% <100.0%> (ø)
opentelemetry/src/context.rs 92.1% <0.0%> (-0.8%) ⬇️
opentelemetry-otlp/src/span.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dd6e7...7347a59. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TommyCpp TommyCpp merged commit d70a537 into main Jun 9, 2021
@jtescher jtescher deleted the update-examples branch June 9, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants