feat: allow users to use different channels based on runtime in batch span processor #560
+270
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… span processor. Resole open-telemetry#520.
Codecov Report
@@ Coverage Diff @@
## main #560 +/- ##
=====================================
Coverage 54.5% 54.6%
=====================================
Files 97 98 +1
Lines 8534 8550 +16
=====================================
+ Hits 4659 4669 +10
- Misses 3875 3881 +6
Continue to review full report at Codecov.
|
* Add error messages based on error type.
Note that the types we used in `batch_message_channel` function and `TrySend` trait are all from `trace` mod. But the runtime doesn't live in trace mod. So we use another trait `TraceRuntime` to include all function and types that related `trace` mod
|
@jtescher I realized that the implementation used types from |
|
@TommyCpp seems good 👍 |
|
I tested a POC of the custom channel from the unbounded channel and it didn't seem to outperform the runtime version. I'd suggest we merge this PR as we have been investigating this issue for a while. |
frigus02
approved these changes
Jun 5, 2021
|
Great work @TommyCpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #520.
Close #533
Another proposed solution to remove mutex in batch span processors.
I tried to keep the type parameter within the channel types. But I don't think I figure out a way to do so without introducing a type parameter in
Runtime. So currently allSenders andReceivers fromRuntimewill have item type asBatchMessage. Let me know there are better way to handle this.TODO: