Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug loop, add notes for #[tokio::test] #552

Merged
merged 2 commits into from May 18, 2021

Conversation

TommyCpp
Copy link
Contributor

fixes #536 #550

fixes open-telemetry#550. We choose to break the loop at instrument level because debug info on `Accumulator` can be found via other structs and descriptors seem to be more important for instruments.
@TommyCpp TommyCpp requested a review from a team as a code owner May 18, 2021 01:51
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #552 (9a434e4) into main (88e779d) will increase coverage by 2.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #552     +/-   ##
=======================================
+ Coverage   52.2%   54.5%   +2.3%     
=======================================
  Files         96      97      +1     
  Lines       8506    8534     +28     
=======================================
+ Hits        4447    4659    +212     
+ Misses      4059    3875    -184     
Impacted Files Coverage Δ
opentelemetry/src/lib.rs 100.0% <ø> (ø)
opentelemetry/src/sdk/metrics/mod.rs 18.6% <100.0%> (+18.6%) ⬆️
opentelemetry/src/sdk/trace/span_processor.rs 81.4% <0.0%> (-0.1%) ⬇️
opentelemetry/src/metrics/counter.rs 100.0% <0.0%> (ø)
opentelemetry/src/global/trace.rs 15.6% <0.0%> (+0.2%) ⬆️
opentelemetry/src/sdk/export/metrics/mod.rs 1.1% <0.0%> (+1.1%) ⬆️
opentelemetry/src/metrics/number.rs 44.5% <0.0%> (+3.6%) ⬆️
opentelemetry/src/sdk/metrics/selectors/simple.rs 4.3% <0.0%> (+4.3%) ⬆️
opentelemetry/src/sdk/resource.rs 78.7% <0.0%> (+4.6%) ⬆️
opentelemetry/src/util.rs 27.7% <0.0%> (+11.1%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e779d...9a434e4. Read the comment docs.

@jtescher jtescher merged commit ebb950a into open-telemetry:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentelemetry::global::shutdown_tracer_provider() Hangs indefinitely, and other troubles
3 participants