Expose the Error type to allow users to set custom error handlers
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne their own error handlers. This is currently impossible because `Error` is private and therefore users cannot provide a function that satisfies the constraints of `set_error_handler`.
TommyCpp
reviewed
May 13, 2021
TommyCpp
approved these changes
May 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=====================================
Coverage 52.2% 52.2%
=====================================
Files 96 96
Lines 8506 8506
=====================================
Hits 4447 4447
Misses 4059 4059
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
Errortype in theglobalmodule to allow users to define their own error handlers.This is currently impossible because
Erroris private and therefore users cannot provide a function that satisfies the constraints ofset_error_handler.