Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp surf support enables default curl client #544

Closed
joshtriplett opened this issue May 8, 2021 · 4 comments · Fixed by #546
Closed

otlp surf support enables default curl client #544

joshtriplett opened this issue May 8, 2021 · 4 comments · Fixed by #546
Labels
question Further information is requested

Comments

@joshtriplett
Copy link

I'd like to use surf with h1-client-rustls, rather than the default curl-client. Would it be possible for otlp's surf support to use default-features = false and support whatever the default surf client is?

@TommyCpp
Copy link
Contributor

TommyCpp commented May 9, 2021

You can implement HttpClient. Then you can build your own HTTP client and set it via HttpConfig to OTLP pipeline.

@TommyCpp TommyCpp added the question Further information is requested label May 9, 2021
@joshtriplett
Copy link
Author

I realize that, but it would be nice to use the existing built-in support and just disable the specific feature forcing the use of curl-client.

@jtescher
Copy link
Member

jtescher commented May 9, 2021

@joshtriplett is #546 what you had in mind?

@joshtriplett
Copy link
Author

@jtescher Yes, that's extremely helpful, thank you! I'll give that a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants