feat: add an example on how to config multiple span processors. #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an example that export spans to both Jaeger and Zipkin to show how to config multiple span processors/exporters. * Remove the `with_batch_exporter` function in `TracerProviderBuilder` as it's the same as the `with_span_processor`. * Rename the `with_default_batch_exporter` function in `TracerProvderBuilder` to `with_batch_exporter` to keep it consistent with the `with_simple_exporter`. * Add `init_exporter` method in Zipkin's builder to allow user build a zipkin exporter
TommyCpp
force-pushed
the
jaeger-and-zipkin
branch
from
d6c0c39
to
38630b8
Compare
Codecov Report
@@ Coverage Diff @@
## main #539 +/- ##
=====================================
Coverage 52.2% 52.2%
=====================================
Files 96 96
Lines 8506 8506
=====================================
Hits 4447 4447
Misses 4059 4059
Continue to review full report at Codecov.
|
jtescher
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example that export spans to both Jaeger and Zipkin to show how to config multiple span processors/exporters.
Remove the
with_batch_exporterfunction inTracerProviderBuilderas it's the same as thewith_span_processor.Rename the
with_default_batch_exporterfunction inTracerProvderBuildertowith_batch_exporterto keep it consistent with thewith_simple_exporter.Add
init_exportermethod in Zipkin's builder to allow user build a zipkin exporter