Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update metrics proto and metric transformation. #535

Merged
merged 1 commit into from May 2, 2021

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Apr 30, 2021

  • Removed all IntXXX objects as they will be removed in coming months and are currently deprecated.
  • Updated Grpcio generated files.

@TommyCpp TommyCpp requested a review from a team as a code owner April 30, 2021 00:07
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #535 (395c05e) into main (3ff1802) will not change coverage.
The diff coverage is n/a.

❗ Current head 395c05e differs from pull request most recent head baca05f. Consider uploading reports for the commit baca05f to get more accurate results
Impacted file tree graph

@@          Coverage Diff          @@
##            main    #535   +/-   ##
=====================================
  Coverage   52.2%   52.2%           
=====================================
  Files         96      96           
  Lines       8513    8513           
=====================================
  Hits        4451    4451           
  Misses      4062    4062           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff1802...baca05f. Read the comment docs.

precommit.sh Show resolved Hide resolved
@djc
Copy link
Contributor

djc commented Apr 30, 2021

Most of the changes look good to me, maybe some discussion about the precommit hook change is warranted (it doesn't seem to really fit in with this PR).

@jtescher jtescher merged commit a9f1453 into open-telemetry:main May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants