Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropped attribute counts to events and links #529

Merged
merged 1 commit into from Apr 22, 2021

Conversation

jtescher
Copy link
Member

No description provided.

@jtescher jtescher requested a review from a team as a code owner April 21, 2021 17:59
@jtescher jtescher requested a review from TommyCpp April 21, 2021 17:59
@jtescher
Copy link
Member Author

@TommyCpp was looking at the proto and it looks like it needs drop counts per event/link. This seem like the best approach? or given the count requirements there you think there may be a better approach?

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #529 (eabc9d3) into main (d3a9dfb) will decrease coverage by 0.0%.
The diff coverage is 64.7%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #529     +/-   ##
=======================================
- Coverage   52.3%   52.2%   -0.1%     
=======================================
  Files         96      96             
  Lines       8503    8514     +11     
=======================================
+ Hits        4448    4451      +3     
- Misses      4055    4063      +8     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/exporter/thrift/mod.rs 31.2% <0.0%> (-4.5%) ⬇️
opentelemetry/src/sdk/trace/config.rs 29.0% <8.3%> (ø)
opentelemetry/src/trace/link.rs 60.0% <50.0%> (-13.7%) ⬇️
opentelemetry/src/sdk/trace/span.rs 95.0% <92.8%> (+<0.1%) ⬆️
opentelemetry/src/sdk/trace/tracer.rs 85.8% <100.0%> (+0.1%) ⬆️
opentelemetry/src/testing/trace.rs 63.4% <100.0%> (ø)
opentelemetry/src/trace/event.rs 88.8% <100.0%> (+0.6%) ⬆️
opentelemetry/src/context.rs 92.1% <0.0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a9dfb...eabc9d3. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like the most natural way to do so. LGTM.
Sorry, I forgot to change the span_limit variable name into plural.

@jtescher jtescher merged commit 4e7613b into main Apr 22, 2021
@jtescher jtescher deleted the event-link-dropped-attribute-counts branch April 22, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants