Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users to use custom export kind selector. #526

Conversation

TommyCpp
Copy link
Contributor

Follow up on #497, which allows users to bring their own aggregator selector.

Also updated the name of examples.

Follow up on open-telemetry#497, which allows users to bring their own aggregator selector.

Also updated the name of examples.
@TommyCpp TommyCpp requested a review from a team as a code owner April 20, 2021 02:05
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@32f34fb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #526   +/-   ##
======================================
  Coverage        ?   51.1%           
======================================
  Files           ?      95           
  Lines           ?    8395           
  Branches        ?       0           
======================================
  Hits            ?    4296           
  Misses          ?    4099           
  Partials        ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f34fb...c5bffdd. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtescher jtescher merged commit 241dff9 into open-telemetry:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants