Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metrics quantiles #525

Merged
merged 2 commits into from Apr 17, 2021
Merged

Remove metrics quantiles #525

merged 2 commits into from Apr 17, 2021

Conversation

jtescher
Copy link
Member

Quantiles did not end up being part of the current metrics spec

@jtescher jtescher requested a review from a team as a code owner April 17, 2021 17:44
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@1cdf725). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #525   +/-   ##
======================================
  Coverage        ?   51.1%           
======================================
  Files           ?      95           
  Lines           ?    8395           
  Branches        ?       0           
======================================
  Hits            ?    4296           
  Misses          ?    4099           
  Partials        ?       0           
Impacted Files Coverage Δ
...pentelemetry/src/sdk/export/metrics/aggregation.rs 0.0% <ø> (ø)
opentelemetry/src/sdk/export/metrics/mod.rs 0.0% <ø> (ø)
opentelemetry/src/sdk/export/metrics/stdout.rs 0.0% <ø> (ø)
opentelemetry/src/sdk/metrics/aggregators/array.rs 0.0% <ø> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.2% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdf725...3000c67. Read the comment docs.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can hardly say no to +21/-337!

@jtescher jtescher merged commit e756cf6 into main Apr 17, 2021
@jtescher jtescher deleted the remove-quantiles branch April 17, 2021 19:51
@xnorpx
Copy link

xnorpx commented Mar 24, 2022

@djc @jtescher what is the recommendation to get quantiles with this removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants