Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add force_push_tracer_provider function. #512

Merged
merged 3 commits into from Apr 6, 2021
Merged

feat: add force_push_tracer_provider function. #512

merged 3 commits into from Apr 6, 2021

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Apr 6, 2021 •
edited

This helps users to force push all remaining spans within span processors.

fix #499

@TommyCpp TommyCpp requested a review from a team as a code owner April 6, 2021 00:42
@TommyCpp
feat: add force_push_tracer_provider function.
68a2567 
This helps user to force push all remaining spans within span processors
@jtescher
Copy link
Member

jtescher commented Apr 6, 2021

This generally looks good, seems like the name should be force_flush rather than force_push to match the others though right?

@TommyCpp
fix: rename the function from force_push to force_flush to keep it co…
34f260c 
…nsistent across span processors and tracer providers.
@jtescher jtescher merged commit 76b6ec9 into open-telemetry:main Apr 6, 2021
@TommyCpp TommyCpp deleted the tommycpp/499 branch April 6, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flushing spans without shutting down the instrumentation
2 participants
@TommyCpp @jtescher