New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of block_on
#498
Comments
Maybe review the interactions with #494 here? |
I looked at #494, but I think the two issues are orthogonal - am I missing something here? |
Yes #494 is unrelated. It aims to address the span drops problem when the volume of spans is too high. It doesn't really change anything in simple span processor |
#502 may resolve some of the issues around blocking here. |
@LukeMathWalker |
I noticed that
SimpleSpanProcessor
usesfutures::executor::block
to export a span every time it closes.This can be troublesome when running on single-threaded executors (e.g. in tests), leading to a blocking of the executor thread itself. I have been experiencing several test hangs when using
SimpleSpanProcessor
that immediately vanish when using the batch exporter andglobal::shutdown
.I feel it would be more sensible to make
SpanProcessor::on_end
asynchronous:exporter.export
;Unfortunately I am not familiar with the overall architecture of the crate, so I do not have an appreciation for the impact on the API of such a change (that's why I am opening an issue instead of a PR 😁 )
The text was updated successfully, but these errors were encountered: