-
Notifications
You must be signed in to change notification settings - Fork 516
Merge opentelemetry-stackdriver into this repo. #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jasonahills @luisholanda can you guys agree to the CLA here? |
Note, I've been a fairly substantial contributor to this project for the last few months -- I would be continuing my maintenance on this crate as part of the otel repo organization. There might be an issue here because opentelemetry-stackdriver depends on tracing-opentelemetry, which depends on opentelemetry but does not live in this repository (and generally gets updated a bit slower than stuff in this repository). |
That's true @djc but that's only a dependency because of the example. I've deleted the example for now as it's non-trivial to get it working from this location. So, we can put off that problem. |
Oh, good call! |
I have no idea why CI is failing at this point. I can't reproduce that problem locally, and I'm not getting any useful info from the CI logs. |
It's worth noting the code coverage test is the only one using a nightly toolchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xaeroxe the coverage tests are a previous issue, don't worry about those. I think this org has an issue with MIT license, maybe remove and just keep the Apache 2?
@jtescher Done! Thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We may need to edit the README file to move the opentelemetry-stackdriver
into projects maintained by opentelemetry but we can also do that in a different PR. Thanks for the work on this!
Per @djc this PR merges the history of https://github.com/vivint-smarthome/opentelemetry-stackdriver into this repository.
I, the author of this crate, will soon have no further reason to work on this as I'm changing employers. When I informed @djc of this they suggested that we transfer this crate to the open-telemetry organization. That seems like a good idea to me, so this PR aims to accomplish that. If this PR is accepted I'll transfer the ownership on crates.io accordingly.