Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp: mention service.name in kitchen sink cfg doc - closes #475 #476

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

clux
Copy link
Contributor

@clux clux commented Mar 10, 2021

adds a possibly slightly more useful key/value combination for docs.

it's probably a common thing to want to set, even if it's not a thing that otel cares about.

@clux clux requested a review from a team March 10, 2021 22:11
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to do the same change in README?

@clux
Copy link
Contributor Author

clux commented Mar 11, 2021

Done.

Btw would you accept PR for adding OtlpPipelineBuilder::with_service_name like in opentelemetry-jaeger?
Might cater to the common use case a bit more ergonomically.

@TommyCpp
Copy link
Contributor

Btw would you accept PR for adding OtlpPipelineBuilder::with_service_name like in opentelemetry-jaeger?
Might cater to the common use case a bit more ergonomically.

Hmm, I guess the problem here is OTLP still doesn't have the service.name concept, with_service_name would be confusing if users are using a backend that doesn't recognize the service.name resource. But maybe we should make a note in the doc to explain if the backend recognizes a Jaeger-style service name, we can set it via resource.

Co-authored-by: Julian Tescher <julian@tescher.me>
@jtescher jtescher merged commit e17a131 into open-telemetry:main Mar 12, 2021
@clux clux deleted the mention-servicename branch March 12, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants