fix: with_collector_endpoint is error prune. #428
Merged
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 51.57% 51.57%
=======================================
Files 65 65
Lines 5117 5117
=======================================
Hits 2639 2639
Misses 2478 2478 Continue to review full report at Codecov.
|
Fix open-telemetry#426. Now we will store the result of try_from function until we init the uploader. If the result is error, we wrap it into TraceError and return.
TommyCpp
force-pushed
the
tommycpp/426
branch
from
75aa90b to
28d1f8c
Compare
jtescher
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #426.
Now we will store the result of try_from function until we init the uploader. If the result is error, we wrap it into TraceError and return.