Missing metrics creator fns #425
Merged
+111
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 51.55% 51.57% +0.01%
==========================================
Files 65 65
Lines 5117 5117
==========================================
+ Hits 2638 2639 +1
+ Misses 2479 2478 -1
Continue to review full report at Codecov.
|
TommyCpp
reviewed
Jan 14, 2021
djc
approved these changes
Jan 14, 2021
|
Code changes look good, can either address docs first or in follow up PR |
- same order as api spec (sync then async)
markdingram
force-pushed
the
missing_creator_fns
branch
from
f12fe23 to
5a68470
Compare
jtescher
added a commit
that referenced
this pull request
Jan 18, 2021
This reverts some of the extra instruments introduced in #425. Specifically `Meter::u64_up_down_counter` and `Meter::u64_up_down_sum_observer` which are not necessary because of their type (e.g. a monotonically increasing `up_down_counter` is simply a `counter`).
jtescher
added a commit
that referenced
this pull request
Jan 18, 2021
This reverts some of the extra instruments introduced in #425. Specifically `Meter::u64_up_down_counter` and `Meter::u64_up_down_sum_observer` which are not necessary because of their type (e.g. a monotonically increasing `up_down_counter` is simply a `counter`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks a bit messy, first commit is a consistent reordering of the existing creator fns.
Second commit adds a few that were missing.