Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Views under feature flag #2298

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 11, 2024

Fixes #2295

Changes

  • Move Views under spec_unstable_metrics_views feature flag

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes

Sorry, something went wrong.

@utpilla utpilla requested a review from a team as a code owner November 11, 2024 22:57
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.6%. Comparing base (47d5016) to head (81e1656).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2298   +/-   ##
=====================================
  Coverage   79.6%   79.6%           
=====================================
  Files        123     123           
  Lines      21263   21263           
=====================================
  Hits       16938   16938           
  Misses      4325    4325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We need a changelog entry to include this.

@cijothomas cijothomas merged commit 648710e into open-telemetry:main Nov 12, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Views under opt-in feature flag
3 participants