Skip to content

MeterProvider modified to not do shutdown if user has already shut down #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cijothomas
Copy link
Member

Fixes #1744

Verified

This commit was signed with the committer’s verified signature.
kurtmckee Kurt McKee
@cijothomas cijothomas requested a review from a team as a code owner September 29, 2024 17:45
lalitb and others added 3 commits September 30, 2024 15:18

Verified

This commit was signed with the committer’s verified signature.
kurtmckee Kurt McKee

Verified

This commit was signed with the committer’s verified signature.
kurtmckee Kurt McKee
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (81a95e3) to head (7bcea2b).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter_provider.rs 83.3% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2156     +/-   ##
=======================================
- Coverage   79.2%   79.2%   -0.1%     
=======================================
  Files        121     121             
  Lines      20976   20980      +4     
=======================================
+ Hits       16622   16623      +1     
- Misses      4354    4357      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fmt
fmt
@cijothomas cijothomas merged commit 380a709 into open-telemetry:main Sep 30, 2024
25 checks passed
cijothomas added a commit to cijothomas/opentelemetry-rust that referenced this pull request Oct 4, 2024
…wn (open-telemetry#2156)

Co-authored-by: Lalit Kumar Bhasin <labhas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics SDK] Shutdown false alarm
2 participants