Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid import paths under "Getting Started" #1574

Merged
merged 1 commit into from Feb 24, 2024

Conversation

marcusirgens
Copy link
Contributor

@marcusirgens marcusirgens commented Feb 24, 2024

Updates the "Getting Started" code sample so that it will compile. Also adds a list of required dependencies, so users won't have to figure out the repository structure and how to find the dependencies in the sample.

I would also like to suggest that the maintainers find a way to perform regression tests against this code snippet, it's probably one of the most important pieces of code in the project.

Merge requirement checklist

  • CONTRIBUTING guidelines followed

  • Unit tests added/updated (if applicable)

  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes

    Unsure about this - this is not trivial, and also user-facing, but it might not be appropriate for the changelog.

  • Changes in public API reviewed (if applicable)

    I guess this reviews a previous change in the public API?

@marcusirgens marcusirgens requested a review from a team as a code owner February 24, 2024 16:14
Copy link

linux-foundation-easycla bot commented Feb 24, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.0%. Comparing base (98cd103) to head (b7d45bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1574   +/-   ##
=====================================
  Coverage   66.0%   66.0%           
=====================================
  Files        140     140           
  Lines      19537   19537           
=====================================
  Hits       12903   12903           
  Misses      6634    6634           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdost hdost merged commit d88e83d into open-telemetry:main Feb 24, 2024
15 checks passed
@marcusirgens marcusirgens deleted the update-getting-started branch February 24, 2024 17:15
@cijothomas
Copy link
Member

Thanks. This is also related to #1306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants