Add files to expose the currently used external types. #1303
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdost
force-pushed
the
document-external-types
branch
from
c6d328c to
eb15768
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
cijothomas
reviewed
Oct 17, 2023
cijothomas
reviewed
Oct 17, 2023
TommyCpp
approved these changes
Oct 17, 2023
lalitb
approved these changes
Oct 17, 2023
TommyCpp
requested changes
Oct 19, 2023
hdost
force-pushed
the
document-external-types
branch
3 times, most recently
from
9fb2e60 to
a177573
Compare
To get ready for release candidate, we should keep track of these as it affects how stable we can consider being. Add check to CI.
hdost
force-pushed
the
document-external-types
branch
from
a177573 to
66c4b45
Compare
https://github.com/open-telemetry/opentelemetry-rust/actions/runs/6618694903/job/17977650680 << Added to CI, and verified that it will fail if we don't have something in the list. |
|
Perfect! Thanks for setting this up. I agree this is be enough for now |
TommyCpp
approved these changes
Oct 23, 2023
cijothomas
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get ready for release candidate, we should keep track of these as it affects how stable we can consider being.
Changes
Catalogs currently used External Types.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes