From 9de34eb012b58c327fb3ab9f6a494adc7b59f6a7 Mon Sep 17 00:00:00 2001 From: Harold Dost Date: Tue, 6 Feb 2024 14:53:43 +0100 Subject: [PATCH] opentelemetry: Disable events for NoopLogger NoopLogger should be using a little resources as possible ideally none. This should help accomplish that. --- opentelemetry/CHANGELOG.md | 4 +++- opentelemetry/src/logs/noop.rs | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/opentelemetry/CHANGELOG.md b/opentelemetry/CHANGELOG.md index db83c515ae..06745c3972 100644 --- a/opentelemetry/CHANGELOG.md +++ b/opentelemetry/CHANGELOG.md @@ -6,7 +6,7 @@ - [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Add experimental synchronous gauge. This is behind the feature flag, and can be enabled by enabling the feature `otel_unstable` for opentelemetry crate. -- [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Guidelines to add new unstable/experimental features. +- [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Guidelines to add new unstable/experimental features. ### Changed @@ -27,6 +27,8 @@ gains, and avoids `IndexMap` dependency. This affects `body` and `attributes` of `observe()` calls, and only accept a precreated `AttributeSet` value. [#1421](https://github.com/open-telemetry/opentelemetry-rust/pull/1421) +- Turned off events for NoopLogger to save on operations + [1455](https://github.com/open-telemetry/opentelemetry-rust/issues/1455) ### Removed diff --git a/opentelemetry/src/logs/noop.rs b/opentelemetry/src/logs/noop.rs index 55d3d617a3..c99b891145 100644 --- a/opentelemetry/src/logs/noop.rs +++ b/opentelemetry/src/logs/noop.rs @@ -42,6 +42,6 @@ impl Logger for NoopLogger { fn emit(&self, _record: LogRecord) {} #[cfg(feature = "logs_level_enabled")] fn event_enabled(&self, _level: super::Severity, _target: &str) -> bool { - true + false } }