fix: ForwardingLogger should foward block param #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added tests to verify the default forwarding logger level, and to make sure it actually forwards logs. Fixes open-telemetry#1599
BrianHawley
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd and
kaylareopelle
as code owners
|
@BrianHawley please review the EasyCLA. If you accept it, we will proceed with a review of this PR. Thank you. |
|
@arielvalentin license accepted, thanks. |
arielvalentin
approved these changes
Mar 18, 2024
dazuma
approved these changes
Mar 21, 2024
|
This seems to also be busted when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests to verify the default forwarding logger level, and to make sure it actually forwards logs.
Fixes #1599