chore: Update rubocop version to 1.60.0 #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
force-pushed
the
update-rubocop-160
branch
from
70f400a
to
d67b5ee
Compare
Incorporate Style/ArgumentsForwarding - Use shorthand syntax ... for arguments forwarding.
kaylareopelle
force-pushed
the
update-rubocop-160
branch
from
a9e270c
to
46d8a64
Compare
kaylareopelle
commented
Jan 16, 2024
Comment on lines
-15
to
+19
| def self.with_send_span(channel, tracer, exchange, routing_key, &block) | ||
| def self.with_send_span(channel, tracer, exchange, routing_key, &block) # rubocop:disable Style/ArgumentsForwarding | ||
| attributes = basic_attributes(channel, channel.connection, exchange, routing_key) | ||
| destination = destination_name(exchange, routing_key) | ||
|
|
||
| tracer.in_span("#{destination} publish", attributes: attributes, kind: :producer, &block) | ||
| tracer.in_span("#{destination} publish", attributes: attributes, kind: :producer, &block) # rubocop:disable Style/ArgumentsForwarding |
There was a problem hiding this comment.
Since the tracer.in_span call has arguments that aren't forwarded, we can't replace &block with ... in the method definition args nor the tracer.in_span args. Same is true for example below.
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi and
a team
as code owners
arielvalentin
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the dependabot changes to update rubocop to 1.160.0 into one PR.
This version introduces Style/ArgumentsForwarding, which attempts to replace calls to &block, *args, etc. with ...