fix: error raised for env checks in LogLimits and SpanLimits #4458
+67
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomcgi
force-pushed
the
fix-error-message-format
branch
4 times, most recently
from
da96f65 to
1a795b2
Compare
jomcgi
changed the title
xrmx
approved these changes
Mar 1, 2025
jomcgi
force-pushed
the
fix-error-message-format
branch
2 times, most recently
from
91109ed to
94f10ba
Compare
Current implementation raises a value error trying to create the error message. Updated error message format to use positional instead of named params. Added test cases to validate the correct errors are raised.
jomcgi
force-pushed
the
fix-error-message-format
branch
from
94f10ba to
d31d1cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation raises a value error trying to create the error message.
Updated error message format to use positional instead of named params.
Added test cases to validate the correct errors are raised.
Fixes #4456
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: