feat(sdk-node): add HostDetector as default resource detector
#4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
force-pushed
the
add-host-detector
branch
from
b6bb327
to
4180164
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4566 +/- ##
==========================================
- Coverage 92.85% 92.84% -0.02%
==========================================
Files 328 328
Lines 9494 9494
Branches 2040 2040
==========================================
- Hits 8816 8815 -1
- Misses 678 679 +1
|
Fixes open-telemetry#4282 - Add `HostDetector` to the list of default resource detectors - Add test to make sure host and process values are being set by default - Update from deprecated `sdk.detectResources()` to `sdk.start()` on tests - Update from deprecated `SemanticResourceAttributes.SERVICE_NAME` to `SEMRESATTRS_SERVICE_NAME` on SDK file
maryliag
force-pushed
the
add-host-detector
branch
from
4180164
to
f606a0a
Compare
trentm
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Nice. LGTM.
I'll wait for a day at least before merging to give others a chance to comment, and as I find my comfort zone with https://github.com/open-telemetry/opentelemetry-js/blob/main/CONTRIBUTING.md#general-merge-requirements
| ], | ||
| }); | ||
| sdk.detectResources(); | ||
| sdk.start(); |
There was a problem hiding this comment.
This was solely to resolve a deprecation warning, right?
pichlermarc
reviewed
Mar 25, 2024
pichlermarc
changed the title
HostDetector as default resource detectorHostDetector as default resource detector
pichlermarc
approved these changes
Mar 25, 2024
|
Ah sorry about that - I broke lint when resolving the conflict 😞 |
|
Thank you both for the reviews! 😄 |
6 tasks
This was referenced May 28, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Host resources were not being set by default when initializing node SDK with
NodeSDK.Fixes #4282
Short description of the changes
HostDetectorto the list of default resource detectorssdk.detectResources()tosdk.start()on testsSemanticResourceAttributes.SERVICE_NAMEtoSEMRESATTRS_SERVICE_NAMEon SDK fileType of change
Please delete options that are not relevant.
How Has This Been Tested?
sdk.test.tsChecklist: