Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-aws-lambda): Change endSpan error-logs for forceflush into debug-logs #2753

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Mar 13, 2025

Which problem is this PR solving?

Short description of the changes

  • This log is not an actual error, because it is really just a warning. Thus, change it to debug log.
    • It could be argued that this could be warn log instead, but given the default info log level, these logs appear in each Lambda invocation when TracerProvider and/or MeterProvider are not configured, which is a bit noisy for logs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙂

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (b520d04) to head (9d40386).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2753   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         171      171           
  Lines        8172     8172           
  Branches     1660     1660           
=======================================
  Hits         7480     7480           
  Misses        692      692           
Files with missing lines Coverage Δ
...-instrumentation-aws-lambda/src/instrumentation.ts 94.52% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc merged commit 4b51e60 into open-telemetry:main Mar 13, 2025
20 checks passed
@dyladan dyladan mentioned this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants