Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-pg): prevent net.peer.port from being NaN #1982

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Mar 1, 2024

Which problem is this PR solving?

Fixes #1980

Short description of the changes

  • when there's a non-number port is in the parameters object, we fall back to undefined

@pichlermarc pichlermarc requested a review from a team March 1, 2024 10:18
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #1982 (6f61bdd) into main (7106313) will increase coverage by 0.00%.
Report is 12 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 6f61bdd differs from pull request most recent head da7b54d. Consider uploading reports for the commit da7b54d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         146      146           
  Lines        7492     7496    +4     
  Branches     1501     1502    +1     
=======================================
+ Hits         6820     6824    +4     
  Misses        672      672           
Files Coverage Δ
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.08% <100.00%> (+0.11%) ⬆️

Copy link
Contributor

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pichlermarc pichlermarc merged commit 3b2090b into open-telemetry:main Mar 8, 2024
12 checks passed
@pichlermarc pichlermarc deleted the fix/pg-nan-port branch March 8, 2024 18:35
@dyladan dyladan mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instrumentation-pg: Invalid trace output if port=null
4 participants