Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left-over TODO in otlploghttp #5256

Merged
merged 1 commit into from Apr 23, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 23, 2024

No description provided.

@MrAlias MrAlias added documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry labels Apr 23, 2024
@XSAM XSAM added this to the v1.26.0 milestone Apr 23, 2024
@MrAlias MrAlias marked this pull request as ready for review April 23, 2024 16:27
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (fe8e3a1) to head (735075c).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5256   +/-   ##
=====================================
  Coverage   84.5%   84.6%           
=====================================
  Files        258     258           
  Lines      17349   17349           
=====================================
+ Hits       14676   14678    +2     
+ Misses      2362    2360    -2     
  Partials     311     311           
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/exporter.go 91.6% <ø> (ø)

... and 1 file with indirect coverage changes

@pellared pellared merged commit ae55e29 into open-telemetry:main Apr 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants