Default implementation for empty BatchProcessor #5239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure an empty
BatchProcessor
does not panic when any method is called. The emptyBatchProcessor
is treated as a shut downBatchProcessor
.Implementing a
BatchProcessor
as shut down instead of initializing with defaults and environment variables is done here to simplify the implementation (there will be a race condition that needs resolution betweenOnEmit
andShutdown
) and for performance ofOnEmit
. We want to ensure the highest performance ofOnEmit
in the standard use case as best we can. Having to check for initialization when this is called will reduce that performance.Part of #5063