Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resource serialization for stdoutlog #5213

Merged
merged 12 commits into from Apr 22, 2024

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Apr 15, 2024

resolves #5211

Adding tests for this behavior is not easy until a test record structure like #5200 is implemented. I will include the test on #5212.

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 15, 2024
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.5%. Comparing base (6e92163) to head (4a7013e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5213     +/-   ##
=======================================
- Coverage   85.5%   85.5%   -0.1%     
=======================================
  Files        258     258             
  Lines      17030   17031      +1     
=======================================
  Hits       14570   14570             
- Misses      2152    2153      +1     
  Partials     308     308             
Files Coverage Δ
exporters/stdout/stdoutlog/record.go 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes

@pellared
Copy link
Member

@open-telemetry/go-approvers This needs a review from a non-Splunker.

@pellared pellared merged commit 9370c5a into open-telemetry:main Apr 22, 2024
26 checks passed
@XSAM XSAM deleted the fix-resource-serialization branch April 22, 2024 12:45
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

stdoutlog: Implement Resource serialization
4 participants