Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: Add allocation tests #4957

Merged
merged 6 commits into from Feb 22, 2024
Merged

log: Add allocation tests #4957

merged 6 commits into from Feb 22, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 21, 2024 •
edited

Resolve #4916

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry labels Feb 21, 2024
@MrAlias MrAlias force-pushed the alloc-tests branch 2 times, most recently from f0f2ef3 to fd5fa0b Compare February 21, 2024 21:21
@MrAlias MrAlias closed this Feb 21, 2024
@MrAlias MrAlias reopened this Feb 21, 2024
@MrAlias MrAlias marked this pull request as ready for review February 21, 2024 21:30
XSAM
XSAM approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pellared
pellared requested changes Feb 22, 2024
View reviewed changes
log/record_test.go Show resolved Hide resolved
log/record_test.go Show resolved Hide resolved
@pellared pellared changed the title Add allocation tests log: Add allocation tests Feb 22, 2024
pellared
pellared reviewed Feb 22, 2024
View reviewed changes
log/record_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the v1.24.0 milestone Feb 22, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 22, 2024

Removed the AsAny tests based on #4962

@MrAlias MrAlias mentioned this pull request Feb 22, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ea99af) 82.9% compared to head (43bf05e) 82.9%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4957   +/-   ##
=====================================
  Coverage   82.9%   82.9%           
=====================================
  Files        238     238           
  Lines      19182   19182           
=====================================
+ Hits       15903   15905    +2     
+ Misses      2987    2985    -2     
  Partials     292     292

see 1 file with indirect coverage changes

pellared
pellared approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pellared pellared merged commit 7cc660f into open-telemetry:main Feb 22, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@pellared pellared pellared approved these changes

@XSAM XSAM XSAM approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.24.0/v0.46.0
Development

Successfully merging this pull request may close these issues.

Add allocation unit tests to log package
5 participants
@MrAlias @dashpole @pellared @XSAM @hanyuancheung