Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: Empty Value #4953

Closed
pellared opened this issue Feb 21, 2024 · 0 comments · Fixed by #5076
Closed

log: Empty Value #4953

pellared opened this issue Feb 21, 2024 · 0 comments · Fixed by #5076
Assignees
@XSAM
Labels
area:logs Part of OpenTelemetry logs pkg:API Related to an API package
Milestone
v1.25.0

Comments

@pellared
Copy link
Member

pellared commented Feb 21, 2024 •
edited

I think that that it would be good to document that an empty value (zero value of value) is valid.

Moreover, maybe we should add Empty() and EmptyValue() factory functions?
Personally, I do not find it necessary, but you can consider creating an issue if you think that it needs to be discussed.

Originally posted by @pellared in #4949 (comment)

Blocked by:
@pellared pellared added pkg:API Related to an API package blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made area:logs Part of OpenTelemetry logs labels Feb 21, 2024
@pellared pellared mentioned this issue Feb 21, 2024
Merged
@pellared pellared removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Mar 13, 2024
@XSAM XSAM self-assigned this Mar 14, 2024
@XSAM XSAM mentioned this issue Mar 14, 2024
Merged
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XSAM XSAM

Labels
area:logs Part of OpenTelemetry logs pkg:API Related to an API package
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.25.0
Development

Successfully merging a pull request may close this issue.

logs: Add empty value for KeyValue XSAM/opentelemetry-go
3 participants
@pellared @MrAlias @XSAM