Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/global: Export getLogger and refactor tests #4951

Closed
pellared opened this issue Feb 21, 2024 · 0 comments · Fixed by #4969
Closed

internal/global: Export getLogger and refactor tests #4951

pellared opened this issue Feb 21, 2024 · 0 comments · Fixed by #4969
Assignees
@MrAlias
Milestone
v1.25.0

Comments

@pellared
Copy link
Member

pellared commented Feb 21, 2024 •
edited

I think we should export global.getLogger to avoid copy-pasting of

var stdLogger = stdr.New(golog.New(os.Stderr, "", golog.LstdFlags|golog.Lshortfile))

in unit tests.

Originally posted by @pellared in #4949 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
v1.25.0
Development

Successfully merging a pull request may close this issue.

Export internal/global.getLogger MrAlias/opentelemetry-go
2 participants
@pellared @MrAlias